Efrat19 commented on code in PR #289:
URL:
https://github.com/apache/flink-connector-kafka/pull/289#discussion_r3838092966
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -574,7 +570,7 @@ private void sendMetadataUpdateEventToAvailableReaders() {
* not assigning to the offsets prior to reader restart). Split offset
resolution is mostly
* managed by the readers.
*
- * <p>NOTE: Must run on coordinator thread
+ * <p>NOTE: Must run on gate thread
Review Comment:
```suggestion
* <p>NOTE: Must run on coordinator thread
```
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -555,10 +551,10 @@ private Set<KafkaStream>
handleFetchSubscribedStreamsError(
}
}
- /** NOTE: Must run on coordinator thread. */
+ /** NOTE: Must run on gate thread. */
Review Comment:
```suggestion
/** NOTE: Must run on coordinator thread. */
```
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -706,11 +702,11 @@ private void
handleAsynchronousEnumeratorCloseFailure(Exception e) {
() -> {
throw new RuntimeException(e);
});
- } catch (Throwable coordinatorFailure) {
+ } catch (Throwable gateFailure) {
Review Comment:
```suggestion
} catch (Throwable coordinatorFailure) {
```
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -706,11 +702,11 @@ private void
handleAsynchronousEnumeratorCloseFailure(Exception e) {
() -> {
throw new RuntimeException(e);
});
- } catch (Throwable coordinatorFailure) {
+ } catch (Throwable gateFailure) {
logger.warn(
"Unable to propagate asynchronous dynamic Kafka enumerator
close failure to "
- + "the coordinator thread. The failure will be
rethrown during close.",
- coordinatorFailure);
+ + "the gate thread. The failure will be rethrown
during close.",
+ gateFailure);
Review Comment:
```suggestion
coordinatorFailure);
```
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -706,11 +702,11 @@ private void
handleAsynchronousEnumeratorCloseFailure(Exception e) {
() -> {
throw new RuntimeException(e);
});
- } catch (Throwable coordinatorFailure) {
+ } catch (Throwable gateFailure) {
logger.warn(
"Unable to propagate asynchronous dynamic Kafka enumerator
close failure to "
- + "the coordinator thread. The failure will be
rethrown during close.",
- coordinatorFailure);
+ + "the gate thread. The failure will be rethrown
during close.",
Review Comment:
```suggestion
+ "the coordinator thread. The failure will be
rethrown during close.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
