weiqingy commented on code in PR #885: URL: https://github.com/apache/flink-agents/pull/885#discussion_r3840642703
########## docs/content/docs/operations/configuration.md: ########## @@ -170,6 +170,8 @@ The eight `memory.generate-event*` options have no raw `ConfigOption` default. W |------------------------------|------------------|---------|------------------------------------------------------------------------------------------| | `actionStateStoreBackend` | (none) | String | The backend for action state store. Supported values: `"kafka"`, `"fluss"`. | +Durable action state stores currently join raw Flink keys and other key parts with an unescaped `_`. Flink keys containing `_` cannot be parsed safely during pruning, so both Kafka and Fluss retain their state in memory and backend storage. Kafka also emits no tombstones for those keys. Review Comment: nit: the Fluss claim and the divergence-cleanup cost both read accurately now across all three sites, so those two are closed. On the key encoding I also had a look at #1010, but that one is about foreign-key retention after a restore, so the encoding itself still has nowhere to point. ########## docs/content/docs/operations/deployment.md: ########## @@ -92,7 +92,7 @@ After recovery from a checkpoint, Flink Agents reprocess events that arrived aft ### Exactly-Once Action Consistency -To ensure exactly-once action consistency, you must configure an external action state store. Flink Agents record action state in this store on a per-action basis. After recovering from a checkpoint, Flink Agents consult the external store and will not re-execute actions that were already completed. This guarantees each action is executed exactly once after recovering from a checkpoint. +To ensure exactly-once action consistency, you must configure an external action state store. Flink Agents record action state in this store on a per-action basis. After recovering from a checkpoint, Flink Agents consult the external store and reuse completed action state when its backing record remains available. This prevents re-execution for checkpoints supported by the store's retained recovery history. Review Comment: nit: the hedge is gone, thanks. That was my wording though. I quoted only the last sentence and called it the original, so the one before it got dropped along the way. On `main` the paragraph also has "After recovering from a checkpoint, Flink Agents consult the external store and will not re-execute actions that were already completed." Without it, "This guarantees..." now attaches to recording state per action rather than to the consult-and-skip behavior it described. Worth putting back? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
