joeyutong commented on code in PR #1030: URL: https://github.com/apache/flink-agents/pull/1030#discussion_r3840838855
########## runtime/src/test/java/org/apache/flink/agents/runtime/memory/MemoryUpdateReplayerTest.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.agents.runtime.memory; + +import org.apache.flink.agents.api.context.MemoryObject; +import org.apache.flink.agents.api.context.MemoryUpdate; +import org.junit.jupiter.api.Test; + +import java.util.LinkedList; +import java.util.List; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatCode; + +/** + * Tests for {@link MemoryUpdateReplayer}: durable-execution replay of the {@link MemoryUpdate}s + * recorded by a completed action must reproduce the action's memory effects, in particular for + * updates recorded by {@code newObject}, which are not value writes. + */ +public class MemoryUpdateReplayerTest { + + private static MemoryObject freshMemory(List<MemoryUpdate> updates) throws Exception { + return new MemoryObjectImpl( + MemoryObject.MemoryType.SHORT_TERM, + new CachedMemoryStore(new ForTestMemoryMapState<>()), + MemoryObjectImpl.ROOT_KEY, + updates); + } + + /** Runs an "action" against a fresh memory and returns the updates it recorded. */ + private static List<MemoryUpdate> recordUpdates(ThrowingConsumer<MemoryObject> action) + throws Exception { + List<MemoryUpdate> updates = new LinkedList<>(); + MemoryObject memory = freshMemory(updates); + action.accept(memory); + return updates; + } + + @FunctionalInterface + private interface ThrowingConsumer<T> { + void accept(T t) throws Exception; + } + + @Test + void testReplayNewObjectWithChildWritesIntoEmptyState() throws Exception { Review Comment: Could we add a case containing only newObject("empty") and assert that replay preserves an empty nested object rather than a null leaf? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
