davidradl commented on code in PR #254:
URL:
https://github.com/apache/flink-connector-aws/pull/254#discussion_r3842074491
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/KinesisShardSplitReaderBase.java:
##########
@@ -179,31 +184,47 @@ private boolean
skipUntilScheduledFetchTime(KinesisShardSplitState splitState)
}
/**
- * Schedules next fetch time, to be called immediately on the result of a
fetchRecords() call.
+ * Schedules the next fetch time. To be called immediately after a
fetchRecords() call.
Review Comment:
this reads strangely "Schedules the next fetch time". We are scheduling the
next fetch not the fetch time.
Would something like this be better as the top level summary of the method:
`Schedules the next fetch at the appropriate time in the future. `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
