auroflow commented on code in PR #29002:
URL: https://github.com/apache/flink/pull/29002#discussion_r3844259140
##########
flink-python/pyflink/dataframe/tests/test_dataframe.py:
##########
@@ -1080,28 +1304,40 @@ def test_basic_functionality(self):
lambda current: current["age"] + 1,
)
.with_column("age", pf.col("age") + 1)
- .select(
- "id",
- "name",
- "age",
- age_next_year=pf.col("age_next_year"),
- inferred_int=pf.lit(2),
- inferred_string=pf.lit("x"),
- explicit_int=pf.lit(3, pf.DataType.int64()),
- explicit_large_int=pf.lit(1 << 40, pf.DataType.int64()),
- explicit_string=pf.lit("y", pf.DataType.string()),
- null_int=pf.lit(None, pf.DataType.int64()),
- null_string=pf.lit(None, pf.DataType.string()),
- non_nullable_int=pf.lit(
- 3,
- pf.DataType(TableDataTypes.BIGINT().not_null()),
- ),
+ .with_columns(
+ (pf.col("age_next_year") + 1).alias("age_in_two_years"),
+ score_percent=pf.col("score") * 100,
+ )
+ .drop("score", "city", "destination")
+ .rename({"name": "customer_name"})
+ .pipe(
Review Comment:
Makes sense, `pipe` does not involve runtime logic. I have removed this call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
