davidradl commented on code in PR #254:
URL:
https://github.com/apache/flink-connector-aws/pull/254#discussion_r3855039961
##########
docs/content.zh/docs/connectors/table/kinesis.md:
##########
@@ -39,10 +39,72 @@ Dependencies
Kinesis 连接器目前并不包含在 Flink 的二进制发行版中，请查阅[这里]({{< ref
"docs/dev/configuration/overview" >}})了解如何在集群运行中引用 Kinesis 连接器。
+### Versioning
+
+There are two available Table API and SQL distributions for the Kinesis
connector.
+This has resulted from an ongoing migration from the deprecated
`SourceFunction` and `SinkFunction` interfaces to the new `Source` and `Sink`
interfaces.
+
+The Table API and SQL interfaces in Flink only allow one TableFactory for each
connector identifier.
+Only one TableFactory with identifier `kinesis` can be included in your
application's dependencies.
+
+The following table clarifies the underlying interface that is used depending
on the distribution selected:
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 40%">Dependency</th>
+ <th class="text-center" style="width: 10%">Connector Version</th>
+ <th class="text-center" style="width: 25%">Source connector identifier
(interface)</th>
+ <th class="text-center" style="width: 25%">Sink connector identifier
(interface)</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td><code>flink-sql-connector-aws-kinesis-streams</code></td>
+ <td><code>5.x</code> or later</td>
+ <td><code>kinesis</code>(<code>Source</code>)</td>
+ <td><code>kinesis</code>(<code>Sink</code>)</td>
+ </tr>
+ <tr>
+ <td><code>flink-sql-connector-aws-kinesis-streams</code></td>
+ <td><code>4.x</code> or earlier</td>
+ <td>N/A (no source packaged)</td>
+ <td><code>kinesis</code>(<code>Sink</code>)</td>
+ </tr>
+ <tr>
+ <td><code>flink-sql-connector-kinesis</code></td>
+ <td><code>5.x</code> or later</td>
+ <td><code>kinesis</code>(<code>Source</code>),
<code>kinesis-legacy</code>(<code>SourceFunction</code>)</td>
Review Comment:
I am not an expert at this but it looks like the kinesis-legacy supports a
higher code level (5 or greater) than the kinesis (4.x). I would expect
something called legacy to be associated with lower versions than the non
legacy.
I see there is an ongoing issue
(https://issues.apache.org/jira/browse/FLINK-36671), but this naming seems
strange to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
