Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3232#discussion_r98443208
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/functions/PythonMapPartition.java
---
@@ -32,7 +32,7 @@
private final PythonStreamer streamer;
private transient final TypeInformation<OUT> typeInformation;
- public PythonMapPartition(int id, TypeInformation<OUT> typeInformation)
{
+ public PythonMapPartition(String id, TypeInformation<OUT>
typeInformation) {
--- End diff --
i would propose explicitly passing the envID and setID. Makes it a lot
clearer, and we don't have to split a string that we created a second ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
