SEPURI-SAI-KRISHNA commented on PR #29037: URL: https://github.com/apache/flink/pull/29037#issuecomment-5477144118
Thanks for picking these up. Checked the update: `MultipleInputStreamTaskIdleDrainTest` is genuinely red/green here, without the `MultipleInputStreamTask` hunk it fails with `actual: [WatermarkStatus(IDLE)]`, with it green. Since dropping the guard was my suggestion I also ran the finished-on-restore paths against `be2272f`: `MultipleInputStreamTaskTest`, `MultipleInputStreamTaskChainedSourcesCheckpointingTest`, `StreamTaskFinalCheckpointsTest`, `SourceOperatorStreamTaskTest`, `SourceStreamTaskTest`, `OneInputStreamTaskTest`, `TwoInputStreamTaskTest` and the new test, 136/136 green, plus 3/3 in `ChainingOutputIdleMaxWatermarkTest`. Worth noting for the record that `FinishedOperatorChain` goes through the normal `OperatorChain` constructor, so `chainedSources` is populated and the loop really does run on a task deployed as finished, the dedup is what makes the unconditional ACTIVE safe, as your new comment says. LGTM, non-binding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
