1996fanrui opened a new pull request, #29058:
URL: https://github.com/apache/flink/pull/29058
## What is the purpose of the change
`LocalInputChannel.getNextBuffer()` always entered `synchronized
(recoveredBuffers)` to check recovery
state, even for channels that never needed recovery (where `inRecovery` is
always false and
`recoveredBuffers` always empty, so the block is dead). `needsRecovery` is a
final field, so gating the
recovery block on it lets steady-state non-recovery channels skip the
monitor on the hot path.
## Brief change log
- [FLINK-40524] Wrap the recovery block in
`LocalInputChannel#getNextBuffer` in an `if (needsRecovery)` gate so channels
that never recover skip the `recoveredBuffers` monitor.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Behavior is identical when
`needsRecovery` is true; the only change is the added gate (the wrapped
block is reindented accordingly).
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes (removes
a lock acquisition on the `getNextBuffer` hot path)
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
