1996fanrui opened a new pull request, #29052:
URL: https://github.com/apache/flink/pull/29052
## What is the purpose of the change
`NetworkActionsLogger.tracePersist(String, Buffer, ...)` computed
`buffer.toDebugString(INCLUDE_HASH)`
(a full buffer copy + hash + string allocation) before delegating to the
trace-guarded overload, so
under backpressure this cost was paid for every persisted in-flight buffer
even when TRACE was off.
This guards the computation behind `isTraceEnabled()`.
## Brief change log
- Guard the `toDebugString` call in
`NetworkActionsLogger.tracePersist(...)` with `LOG.isTraceEnabled()`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage. It
is behavior-preserving:
the delegate overload already no-ops when TRACE is off; only the redundant
debug-string computation is skipped.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes (removes
redundant work on the checkpoint persist path when TRACE is off)
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
