dalelane commented on code in PR #1199:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1199#discussion_r3914098671
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java:
##########
@@ -273,6 +285,24 @@ private static void
setRandomJobResultStorePath(Configuration effectiveConfig) {
}
}
+ private static void setRandomApplicationResultStorePath(Configuration
effectiveConfig) {
+ if (effectiveConfig.contains(HighAvailabilityOptions.HA_STORAGE_PATH))
{
Review Comment:
I so think that's worth fixing, but IMO it's a separate enough issue that
it'd be better in a separate pull request (maybe a separate Jira bug issue too)
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java:
##########
@@ -273,6 +285,24 @@ private static void
setRandomJobResultStorePath(Configuration effectiveConfig) {
}
}
+ private static void setRandomApplicationResultStorePath(Configuration
effectiveConfig) {
+ if (effectiveConfig.contains(HighAvailabilityOptions.HA_STORAGE_PATH))
{
Review Comment:
I do think that's worth fixing, but IMO it's a separate enough issue that
it'd be better in a separate pull request (maybe a separate Jira bug issue too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
