raminqaf commented on code in PR #29101:
URL: https://github.com/apache/flink/pull/29101#discussion_r3933475083
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java:
##########
@@ -218,7 +219,7 @@ public final class LogicalTypeCasts {
castTo(VARCHAR)
.implicitFromFamily(CHARACTER_STRING)
.explicitFromFamily(PREDEFINED, CONSTRUCTED)
- .explicitFrom(RAW, NULL, STRUCTURED_TYPE, BITMAP, VARIANT)
+ .explicitFrom(RAW, NULL, STRUCTURED_TYPE, BITMAP, VARIANT,
UUID)
Review Comment:
Yes, intentional. FLIP-604 specifies `UUID` has no implicit coercions. It
matches Calcite (UUID is assignable only from UUID in `SqlTypeAssignmentRule`)
and PostgreSQL, where uuid has no implicit casts.
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java:
##########
@@ -218,7 +219,7 @@ public final class LogicalTypeCasts {
castTo(VARCHAR)
.implicitFromFamily(CHARACTER_STRING)
.explicitFromFamily(PREDEFINED, CONSTRUCTED)
- .explicitFrom(RAW, NULL, STRUCTURED_TYPE, BITMAP, VARIANT)
+ .explicitFrom(RAW, NULL, STRUCTURED_TYPE, BITMAP, VARIANT,
UUID)
Review Comment:
Yes, intentional. FLIP-604 specifies `UUID` has no implicit coercions. It
matches Calcite (`UUID` is assignable only from `UUID` in
`SqlTypeAssignmentRule`) and PostgreSQL, where uuid has no implicit casts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
