manner commented on code in PR #29103:
URL: https://github.com/apache/flink/pull/29103#discussion_r3934548782
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantUtil.java:
##########
@@ -674,6 +703,20 @@ public static String getString(byte[] value, int pos) {
throw unexpectedType(Type.STRING);
}
+ public static UUID getUUID(byte[] value, int pos) {
+ checkIndex(pos, value.length);
Review Comment:
Mhm, `value.length` should be the size of the whole variant data, not just
the UUID, so I don't think we can compare to that size. And the bounds are
checked inside `readLongBigEndian()` again if the `byte[]` is too short. Maybe
you can clarify which check you mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
