emecii opened a new issue, #1108: URL: https://github.com/apache/flink-agents/issues/1108
## Problem `python/flink_agents/runtime/skill/skill_manager.py` currently suppresses every exception from `SkillRepository.close()` in `SkillManager.close()`. It still attempts later repositories, but a failure is neither re-raised nor logged. As a result, an extension-provided repository cleanup failure is invisible to callers. This differs from the Java `SkillManager.closeRepos()` contract introduced in #987: it attempts every repository close, then rethrows the first failure after the loop. Python `ResourceCache.close()` follows the same close-everything-then-surface-the-first-failure pattern. The current in-tree repository implementations do not raise on close, so this is a contract/parity defect for the public `SkillRepository` extension point rather than a known incident in a bundled repository. ## Proposed direction Make Python `SkillManager.close()` attempt every distinct repository and rethrow the first close failure after the loop, logging later failures consistently with `ResourceCache.close()`. Add focused tests using test repositories whose `close()` raises, including a case that proves later repositories are still closed. This is an observable behavior change, so I am seeking committer support before preparing a PR, as required by the contribution guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
