spuru9 commented on code in PR #29116:
URL: https://github.com/apache/flink/pull/29116#discussion_r3959973139
##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcherTest.java:
##########
@@ -410,8 +409,7 @@ void testCleanUpLazyFetchTaskCancelsRunningFuture() throws
Exception {
archiveStorage, "jobs/" + jobId + "/config");
archiveStorage = blockingStorage;
- HistoryServerArchiveFetcher<?> fetcher =
- createArchiveFetcher(remoteArchiveRootPath, false,
blockingStorage);
+ fetcher = createArchiveFetcher(remoteArchiveRootPath, false,
blockingStorage);
Review Comment:
Ran this test 11x locally (22 executions across both storage backends) —
`close()` consistently completes in 0.17–0.8s, well under the 1s
`gracefulShutdown` timeout. `cancel(true)` interrupts the thread blocked in
`releaseLatch.await()`, and `BlockingArchiveStorage` handles the interrupt
(catches it, converts to `IOException`) rather than swallowing it, so the task
unblocks immediately. No change needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
