gaborgsomogyi commented on PR #29132: URL: https://github.com/apache/flink/pull/29132#issuecomment-5601004505
I've tested this against your `FLINK-39786` concern. Removing the `abort` entirely from plain `close()` (keeping it only in `closeForCommit()`'s existing failure catch) does not touch 39786 fix. Its own tests (`closeForCommitAbortsMultipartUploadWhenPartUploadFails`, `closeForCommitSurfacesAbortFailureWhenBothUploadAndAbortFail`) exercise `closeForCommit()`'s catch block, which stays untouched. What does break are 4 tests asserting plain `close()` current abort behavior: `closeAbortsMultipartUploadOnAbnormalClose` `closeSurfacesAbortFailureInsteadOfSwallowingIt` `closeSurfacesTempFileDeletionFailure` `closeDeletesTempFileRemovedDuringCleanup` Which specific `39786` scenario do you have in mind or something in `closeForCommit()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
