poorbarcode commented on code in PR #127:
URL:
https://github.com/apache/flink-connector-pulsar/pull/127#discussion_r3969453713
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/committer/PulsarCommittable.java:
##########
@@ -18,14 +18,14 @@
package org.apache.flink.connector.pulsar.sink.committer;
-import org.apache.flink.annotation.Internal;
+import org.apache.flink.annotation.PublicEvolving;
import org.apache.pulsar.client.api.transaction.TxnID;
import java.util.Objects;
/** The writer state for Pulsar connector. We would used in Pulsar committer.
*/
-@Internal
+@PublicEvolving
Review Comment:
Removed the change
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/schema/PulsarSchemaTypeSerializer.java:
##########
@@ -200,9 +200,11 @@ public TypeSerializer<T> restoreSerializer() {
return new PulsarSchemaTypeSerializer<>(schema);
}
+ // https://issues.apache.org/jira/browse/FLINK-30614 changed the
definition, BTW the param
+ // is useless for the current project.
Review Comment:
Deleted.
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/schema/PulsarSchemaTypeInformation.java:
##########
@@ -66,8 +66,10 @@ public boolean isKeyType() {
return false;
}
+ // https://issues.apache.org/jira/browse/FLINK-34125 modified the
definition, BTW the param is
+ // useless for the current project.
Review Comment:
Deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
