gaborgsomogyi commented on code in PR #29129:
URL: https://github.com/apache/flink/pull/29129#discussion_r3976339954
##########
flink-filesystems/flink-s3-fs-native/src/test/java/org/apache/flink/fs/s3native/NativeS3FileSystemITCase.java:
##########
@@ -109,6 +109,39 @@ void testMkdirsDoesNotThrowOnObjectStore() {
.doesNotThrowAnyException();
}
+ @Test
+ void testRecursiveDeleteManyFilesWithBatchingEnabled() throws Exception {
Review Comment:
Added more extensive tests in `NativeS3RecursiveDeleteTest`.
##########
flink-filesystems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3FileSystem.java:
##########
@@ -406,6 +419,87 @@ public boolean delete(Path path, boolean recursive) throws
IOException {
}
}
+ /**
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]