slachiewicz commented on PR #313: URL: https://github.com/apache/flink-connector-kafka/pull/313#issuecomment-5622887101
Agreed on all points. Reworking it as: an opt-in variant of `drainAllRecordsFromTopic` for drains that expect open transactions, so the 10 s wait only applies to settled-topic drains; a direct test of `getSettledEndOffsets` for the open, warn, commit, advance sequence; `String.valueOf` for the isolation level; a javadoc line on the fixed high-watermark target. And yes, the "10/10" was one pass over the parameter sets, not ten runs. This PR waits for #314, which is what makes `rescaleListing` pass. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
