gaborgsomogyi opened a new pull request, #29162:
URL: https://github.com/apache/flink/pull/29162
## What is the purpose of the change
The `download-crt-jars.sh` helper in `flink-s3-fs-native` hardcodes the
`mvn` binary name, requiring plain Maven to be present on `PATH`. This fails in
environments where only a Maven wrapper (or a differently named Maven
executable) is available. This pull request adds an `MVN` environment variable
override so the script can invoke any Maven executable, following the same
`MVN=${MVN:-mvn}` convention already used in `tools/releasing/*.sh`.
## Brief change log
- Introduced an `MVN` environment variable (defaulting to `mvn`) in
`download-crt-jars.sh`
- Replaced the hardcoded `mvn` invocations with `"${MVN}"`
- Updated the script's PATH check and documentation comments accordingly
## Verifying this change
Manually tested.
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Claude code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
