MartijnVisser commented on code in PR #306:
URL:
https://github.com/apache/flink-connector-kafka/pull/306#discussion_r3990298958
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
Review Comment:
Every path in the reactor declares commons-cli 1.5.0, javassist 3.24.0-GA
and objenesis 3.4, so there is nothing for these three pins to reconcile. They
can go.
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
+ <commons-codec.version>1.22.1</commons-codec.version>
+ <commons-compress.version>1.28.0</commons-compress.version>
+ <commons-io.version>2.22.0</commons-io.version>
+ <commons-lang3.version>3.20.0</commons-lang3.version>
Review Comment:
commons-lang3 is compile scope for one call,
RandomStringUtils.randomAlphabetic(8). Flink's
StringUtils.generateRandomAlphanumericString covers it, so I think it can move
to test scope. 686 KB off every user's classpath.
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
+ <commons-codec.version>1.22.1</commons-codec.version>
+ <commons-compress.version>1.28.0</commons-compress.version>
+ <commons-io.version>2.22.0</commons-io.version>
+ <commons-lang3.version>3.20.0</commons-lang3.version>
<httpcore.version>4.4.16</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
- <jackson-bom.version>2.21.3</jackson-bom.version>
- <javassist.version>3.30.2-GA</javassist.version>
+ <jackson-bom.version>2.22.2</jackson-bom.version>
Review Comment:
Flink only ships jackson shaded, so this is ours alone to pick. Is master
the right criterion?
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
+ <commons-codec.version>1.22.1</commons-codec.version>
+ <commons-compress.version>1.28.0</commons-compress.version>
+ <commons-io.version>2.22.0</commons-io.version>
+ <commons-lang3.version>3.20.0</commons-lang3.version>
<httpcore.version>4.4.16</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
- <jackson-bom.version>2.21.3</jackson-bom.version>
- <javassist.version>3.30.2-GA</javassist.version>
+ <jackson-bom.version>2.22.2</jackson-bom.version>
+ <javassist.version>3.33.0-GA</javassist.version>
<jsr305.version>1.3.9</jsr305.version>
<kryo.version>5.6.2</kryo.version>
- <log4j.version>2.25.4</log4j.version>
- <objenesis.version>3.4</objenesis.version>
+ <log4j.version>2.26.1</log4j.version>
+ <objenesis.version>3.6</objenesis.version>
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>${scala.binary.version}.20</scala-library.version>
<scala-reflect.version>${scala.binary.version}.20</scala-reflect.version>
<slf4j.version>1.7.36</slf4j.version>
- <snakeyaml.version>2.4</snakeyaml.version>
- <snappy-java.version>1.1.10.7</snappy-java.version>
+ <snakeyaml.version>2.7</snakeyaml.version>
+ <snappy-java.version>1.1.10.8</snappy-java.version>
Review Comment:
kafka-clients asks for 1.1.10.7 and flink-dist ships it, so this pin was a
no-op and now is divergence.
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
+ <commons-codec.version>1.22.1</commons-codec.version>
+ <commons-compress.version>1.28.0</commons-compress.version>
+ <commons-io.version>2.22.0</commons-io.version>
+ <commons-lang3.version>3.20.0</commons-lang3.version>
<httpcore.version>4.4.16</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
- <jackson-bom.version>2.21.3</jackson-bom.version>
- <javassist.version>3.30.2-GA</javassist.version>
+ <jackson-bom.version>2.22.2</jackson-bom.version>
+ <javassist.version>3.33.0-GA</javassist.version>
<jsr305.version>1.3.9</jsr305.version>
<kryo.version>5.6.2</kryo.version>
- <log4j.version>2.25.4</log4j.version>
- <objenesis.version>3.4</objenesis.version>
+ <log4j.version>2.26.1</log4j.version>
+ <objenesis.version>3.6</objenesis.version>
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>${scala.binary.version}.20</scala-library.version>
<scala-reflect.version>${scala.binary.version}.20</scala-reflect.version>
<slf4j.version>1.7.36</slf4j.version>
- <snakeyaml.version>2.4</snakeyaml.version>
- <snappy-java.version>1.1.10.7</snappy-java.version>
+ <snakeyaml.version>2.7</snakeyaml.version>
+ <snappy-java.version>1.1.10.8</snappy-java.version>
<!-- Test Dependencies -->
- <archunit.version>1.4.1</archunit.version>
+ <archunit.version>1.5.0</archunit.version>
<assertj.version>3.27.7</assertj.version>
- <docker-java-api.version>3.5.2</docker-java-api.version>
- <guava.version>33.4.8-jre</guava.version>
+ <docker-java-api.version>3.7.1</docker-java-api.version>
+ <guava.version>33.7.1-jre</guava.version>
<hamcrest.version>1.3</hamcrest.version>
<junit5.version>5.13.3</junit5.version>
<mockito.version>5.18.0</mockito.version>
Review Comment:
enforce-banned-deps below bans org.mockito and org.powermock outright, so
these two pin versions nothing can use. Worth dropping in the same pass.
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
+ <commons-codec.version>1.22.1</commons-codec.version>
+ <commons-compress.version>1.28.0</commons-compress.version>
+ <commons-io.version>2.22.0</commons-io.version>
Review Comment:
Two paths ask for commons-io, 2.15.1 and 2.16.1. 2.19.0 is already a version
neither wants, and 2.22.0 widens that.
##########
pom.xml:
##########
@@ -57,38 +57,38 @@ under the License.
<kafka.version>4.2.0</kafka.version>
<!-- Other Dependencies -->
- <avro.version>1.12.0</avro.version>
+ <avro.version>1.12.2</avro.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
- <commons-cli.version>1.9.0</commons-cli.version>
- <commons-codec.version>1.18.0</commons-codec.version>
- <commons-compress.version>1.27.1</commons-compress.version>
- <commons-io.version>2.19.0</commons-io.version>
- <commons-lang3.version>3.18.0</commons-lang3.version>
+ <commons-cli.version>1.11.0</commons-cli.version>
+ <commons-codec.version>1.22.1</commons-codec.version>
+ <commons-compress.version>1.28.0</commons-compress.version>
+ <commons-io.version>2.22.0</commons-io.version>
+ <commons-lang3.version>3.20.0</commons-lang3.version>
<httpcore.version>4.4.16</httpcore.version>
<httpclient.version>4.5.14</httpclient.version>
- <jackson-bom.version>2.21.3</jackson-bom.version>
- <javassist.version>3.30.2-GA</javassist.version>
+ <jackson-bom.version>2.22.2</jackson-bom.version>
+ <javassist.version>3.33.0-GA</javassist.version>
<jsr305.version>1.3.9</jsr305.version>
<kryo.version>5.6.2</kryo.version>
- <log4j.version>2.25.4</log4j.version>
- <objenesis.version>3.4</objenesis.version>
+ <log4j.version>2.26.1</log4j.version>
+ <objenesis.version>3.6</objenesis.version>
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>${scala.binary.version}.20</scala-library.version>
<scala-reflect.version>${scala.binary.version}.20</scala-reflect.version>
<slf4j.version>1.7.36</slf4j.version>
- <snakeyaml.version>2.4</snakeyaml.version>
- <snappy-java.version>1.1.10.7</snappy-java.version>
+ <snakeyaml.version>2.7</snakeyaml.version>
+ <snappy-java.version>1.1.10.8</snappy-java.version>
<!-- Test Dependencies -->
- <archunit.version>1.4.1</archunit.version>
+ <archunit.version>1.5.0</archunit.version>
<assertj.version>3.27.7</assertj.version>
- <docker-java-api.version>3.5.2</docker-java-api.version>
- <guava.version>33.4.8-jre</guava.version>
+ <docker-java-api.version>3.7.1</docker-java-api.version>
+ <guava.version>33.7.1-jre</guava.version>
<hamcrest.version>1.3</hamcrest.version>
<junit5.version>5.13.3</junit5.version>
<mockito.version>5.18.0</mockito.version>
<powermock.version>2.0.9</powermock.version>
- <snakeyaml.version>2.4</snakeyaml.version>
+ <snakeyaml.version>2.7</snakeyaml.version>
Review Comment:
snakeyaml.version is already set on line 79, so this one is a duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
