gustavodemorais commented on code in PR #29102:
URL: https://github.com/apache/flink/pull/29102#discussion_r3991145006
##########
docs/content/docs/sql/reference/queries/changelog.md:
##########
@@ -297,7 +297,8 @@ SELECT * FROM TO_CHANGELOG(
input => TABLE source_table [PARTITION BY key_col],
[op => DESCRIPTOR(op_column_name),]
[op_mapping => MAP['INSERT', 'I', 'DELETE', 'D', ...],]
- [produces_full_deletes => BOOLEAN]
+ [produces_full_deletes => BOOLEAN,]
+ [include_op_column => BOOLEAN]
Review Comment:
Having an optimal param with false as default feels more intuitive. If the
user wants a different behavior he can set it to true.
```suggestion
[hide_op_column => BOOLEAN]
```
We didn't consider that with produces_full_deletes but it was the way the
FLIP was approved so we didn't change. Open to alternative naming suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
