vbhanuchander-lang commented on PR #309: URL: https://github.com/apache/flink-connector-kafka/pull/309#issuecomment-5640987488
@MartijnVisser #291 landed yesterday, so I have rebased this onto current `main` (`6b99bb3`, which includes it) — the sequencing you asked for is now satisfied and this is no longer waiting on anything. Clean rebase, no conflicts. Re-verified on the rebased tree: - `DynamicKafkaSourceEnumeratorTest` 31/31 and `DynamicKafkaSourceReaderTest` 15/15, 46 tests, 0 failures. I ran the reader class too since #291 changed that side and this change interacts with it. - `spotless:check` and `checkstyle:check` clean **on JDK 17**, confirmed by checking the goal actually executed rather than the exit code — `flink-connector-parent` sets `<skip>true</skip>` for spotless on Java 21, which is what made my earlier runs report success while doing nothing. That was the cause of both red CI rounds. Two things still open from your side rather than mine: 1. **The workflow run is gated.** Every run on this PR has ended at `action_required` because it is my first PR in this repo, so the JDK 11/17/21 legs have never actually executed here — only `Title Validator`. If you or another committer can approve the run, that is the last unverified piece. 2. **Coverage for the metadata-change clear.** Still no test, for the reason in my previous comment: the recreated sub enumerators do not reach the signalling precondition, so the behaviour is unreachable until FLINK-31006. Happy to add a `Whitebox` assertion on the set if you want something now, or to put the real test on the 31006 change so it lands with the behaviour it asserts — your call, and I did not want to pick for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
