weicheng-07 commented on code in PR #29151:
URL: https://github.com/apache/flink/pull/29151#discussion_r3994801987
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java:
##########
@@ -96,4 +100,26 @@ public void close() {
}
super.close();
}
+
+ private static final class JdkBasicAuthHttpConnectionFactory implements
HttpConnectionFactory {
+ private final HttpConnectionFactory connectionFactory = new
DefaultHttpConnectionFactory();
+ private final String authorizationHeader;
+
+ private JdkBasicAuthHttpConnectionFactory(String username, String
password) {
+ // Use the JDK encoder because simpleclient's implementation
requires JAXB.
Review Comment:
Confirmed: URL encoding through `PushGateway.base64url` still depends on
JAXB in simpleclient 0.8.1. This PR remains scoped to Basic Auth header
encoding; the client upgrade is tracked in
[FLINK-29623](https://issues.apache.org/jira/browse/FLINK-29623).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
