MartijnVisser opened a new pull request, #29174:
URL: https://github.com/apache/flink/pull/29174

   ## What is the purpose of the change
   
   The `minio/minio` repository no longer exists on Docker Hub, so every test 
that starts the MinIO container fails on this branch:
   
   ```
   Caused by: com.github.dockerjava.api.exception.NotFoundException: Status 
404: {"message":"pull access denied for minio/minio, repository does not exist 
or may require 'docker login'"}
   ```
   
   This points the image at quay.io, which still serves the same tag at the 
same digest.
   
   master is not affected because FLINK-39499 replaced MinIO with SeaweedFS 
there, so there is no master PR for this one. The same change goes to the other 
two affected release branches.
   
   ## Brief change log
   
     - `DockerImageVersions.MINIO` now points at 
`quay.io/minio/minio:RELEASE.2022-02-07T08-17-33Z`, which resolves to the same 
digest Docker Hub served 
(`sha256:7dda745aefd6152f0d04fdd23377f9e52549df3fc4307f16b8bc562ae2b8119f`)
     - `common_s3_minio.sh` pulled the image untagged and is now pinned to that 
same tag. Current MinIO images fail with `Unable to use the drive /data` on a 
plain bind mount, so the tag cannot be left floating
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`MinioTestContainerTest`, the `HAJobRunOnMinioS3Store` and `S5CmdOnMinio` 
ITCases, and the s3 end-to-end tests.
   
   Verified locally on this branch:
   
     - Before the change, `MinioTestContainerTest` fails 6/6 with the `pull 
access denied` error above
     - After the change, `MinioTestContainerTest` passes 6/6
     - The pinned image was also started by hand with the same arguments 
`common_s3_minio.sh` uses (bind mount, `-P`, 
`MINIO_ACCESS_KEY`/`MINIO_SECRET_KEY`) and serves the S3 API
   
   The s3 end-to-end scripts were not run end to end locally, and `mvn clean 
verify` was not run in full; the affected module was built and tested directly.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no (test infrastructure only)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Opus 5 (1M context)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to