Efrat19 commented on code in PR #285:
URL:
https://github.com/apache/flink-connector-kafka/pull/285#discussion_r4014032597
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java:
##########
@@ -2411,6 +2412,11 @@ private MetadataUpdateEvent getLatestMetadataUpdateEvent(
@SuppressWarnings("unchecked")
private MetadataUpdateEvent getLatestMetadataUpdateEventWithoutContextSync(
MockSplitEnumeratorContext<DynamicKafkaSourceSplit> context, int
readerId) {
+ // Reflection is required here because
MockSplitEnumeratorContext#getSentSourceEvent()
+ // dispatches to workerExecutor and blocks on Future#get(). In tests
that intentionally
+ // block workerExecutor (e.g.
+ //
testProductionMetadataRefreshBypassesBlockedSourceCoordinatorAsyncCallable),
+ // calling getSentSourceEvent() deadlocks.
Review Comment:
Will this also be solved by FLINK-40543?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
