[jira] (FLINK-5642) queryable state: race condition with HeadListState

[ASF GitHub Bot (JIRA)]

Title: Message Title

ASF GitHub Bot commented on FLINK-5642   Re: queryable state: race condition with HeadListState Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3218 Good catch for that problem. I would suggest two changes: 1. Let's forbid `remove()` in all cases, also when the state is non-queryable. It seems inconsistent that the heap-state allows modifications via the iterable, while the RocksDB state does not. 2. It would be nice to get rid of the locking (or the code branch) in the `add()` method: A simple approach is to override `add()` in the queryable state version of the list and synchronize there. A more advanced idea: We may get rid of the locking on the ArrayList alltogether by implementing our own specialized list: Since the list ever only grows (a clear call removes the list as a whole from the map in the heap state) creating a serialized copy means simply taking the list and taking all elements from the list up to the size that are not null (to support `null` we can use a null-marker element). Taking the elements from the list needs to be conservative (take the lower, size or nun-null entries) to compensate for visibility issues across the threads. Add Comment   This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)