MartijnVisser opened a new pull request, #29187:
URL: https://github.com/apache/flink/pull/29187

   ## What is the purpose of the change
   
   Backport of FLINK-39105, fixed on master and release-2.3 by fdc2686e33d and 
not backported. `RestClientTest.testConnectionTimeout` connects to `240.0.0.0` 
with a 1ms connection timeout and asserts `ConnectTimeoutException`. A runner 
without a route gets an immediate rejection from the OS instead, which Netty 
reports as `AnnotatedSocketException`. Both are `SocketException` subtypes, so 
the assertion now expects that, and `hasMessageContaining(unroutableIp)` still 
pins the destination.
   
   Last occurrence on this branch in the nightly of 2026-09-15, 
`test_cron_adaptive_scheduler core`: 
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=79075
   
   ## Brief change log
   
     * `RestClientTest.testConnectionTimeout` expects `SocketException` instead 
of `ConnectTimeoutException`
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `RestClientTest`.
   
     * The condition does not occur locally. Pointing `unroutableIp` at 
`2001:db8:0:0:0:0:0:1` and running with `-Djava.net.preferIPv4Stack=true` makes 
the OS reject the connect first, which gives the same 
`AnnotatedSocketException`. Under that condition the test fails on the base 
commit and passes with this change.
     * `RestClientTest`, the architecture tests, `spotless:check` and 
`checkstyle:check` pass on this branch.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to