1996fanrui opened a new pull request, #29190:
URL: https://github.com/apache/flink/pull/29190
## What is the purpose of the change
A needsRecovery `RemoteInputChannel` starts with zero server credit, and
`upstreamReady` is
opened only by `onBuffer()`, which makes it look like the recovery drain
could stall. It cannot:
the upstream always emits `EndOfOutputChannelStateEvent` at recovery init,
and events bypass the
zero-credit gate, so `onBuffer()` fires and opens the latch. This adds a
comment making that
reasoning explicit.
## Brief change log
- Comment-only, at the `onBuffer()` latch `countDown` in
`RemoteInputChannel`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
