MartijnVisser commented on code in PR #29183:
URL: https://github.com/apache/flink/pull/29183#discussion_r4014997217
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexTest.java:
##########
@@ -96,8 +96,6 @@ void testResetForNewExecutionReleasesPartitions() throws
Exception {
execution.markFinished();
- assertThat(releasePartitionsFuture).isNotDone();
Review Comment:
This also drops the check that finishing the producer does not release its
blocking partitions. The final assertion cannot catch that, since the future
keeps whichever release completed first.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionVertexTest.java:
##########
@@ -96,8 +96,6 @@ void testResetForNewExecutionReleasesPartitions() throws
Exception {
execution.markFinished();
Review Comment:
Both runs linked on the ticket fail at line 95, the assertion before this
call. Removing the one after it leaves the flake in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
