fmorillo7694 commented on PR #206: URL: https://github.com/apache/flink-connector-aws/pull/206#issuecomment-5684965063
@Samrat002 All open review threads are now addressed and resolved as of 002c0fb: - Simplified `GlueCatalog#close()` (removed the retry logic, per @leekeiabstraction's finding that the SDK `close()` is best-effort) - Removed the leftover comment in `GlueCatalogFactory` - Initialized `glueFunctions` in `GlueFunctionOperator#listGlueFunctions` so it can never be null - Added null checks on the `GlueOperator` constructor params - Docs: clarified DataStream API usage via `StreamTableEnvironment` and linked the AWS credentials configuration guide The branch is also synced with `main` (0 commits behind, including the Flink 2.1.2 / connector-parent 2.0.0 bump), module poms bumped to 6.1-SNAPSHOT, missing ASF license headers added, and the new spotless formatting applied. `mvn verify` passes locally (126/126 tests, spotless + RAT clean). The CI workflow run on the new head is waiting for approval (`action_required`) — could you approve it and take another review pass when you get a chance? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
