davidradl commented on code in PR #29191:
URL: https://github.com/apache/flink/pull/29191#discussion_r4015434333
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnknownInputChannel.java:
##########
@@ -192,6 +192,8 @@ public RemoteInputChannel toRemoteInputChannel(
metrics.getNumBytesInRemoteCounter(),
metrics.getNumBuffersInRemoteCounter(),
channelStateWriter == null ? ChannelStateWriter.NO_OP
: channelStateWriter,
+ // Unknown channels exist only in BATCH jobs, which
have no channel
Review Comment:
I was expecting a change to the docs from the PR title. Is there an external
consideration that we could add to the docs around this? Or is this just for
code hygene?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
