MartijnVisser commented on code in PR #28560:
URL: https://github.com/apache/flink/pull/28560#discussion_r4020343212
##########
flink-filesystems/flink-s3-fs-base/src/test/java/org/apache/flink/fs/s3/common/SeaweedFsTestContainer.java:
##########
@@ -71,21 +69,16 @@ public SeaweedFsTestContainer(String defaultBucketName) {
withEnv(AWS_ACCESS_KEY_ID, this.accessKey);
withEnv(AWS_SECRET_ACCESS_KEY, this.secretKey);
withCommand(
- "server", "-s3", "-s3.port=" + DEFAULT_PORT, "-dir=" +
DEFAULT_STORAGE_DIRECTORY);
+ "mini",
Review Comment:
Fair enough, I will take your word that `mini` is the mode to use for tests.
Keep a bucket check after start and I am happy with it.
##########
flink-filesystems/flink-s3-fs-base/src/test/java/org/apache/flink/fs/s3/common/SeaweedFsTestContainer.java:
##########
@@ -71,21 +69,16 @@ public SeaweedFsTestContainer(String defaultBucketName) {
withEnv(AWS_ACCESS_KEY_ID, this.accessKey);
withEnv(AWS_SECRET_ACCESS_KEY, this.secretKey);
withCommand(
- "server", "-s3", "-s3.port=" + DEFAULT_PORT, "-dir=" +
DEFAULT_STORAGE_DIRECTORY);
+ "mini",
+ "-s3.port=" + DEFAULT_PORT,
+ "-dir=" + DEFAULT_STORAGE_DIRECTORY,
+ "-bucket=" + defaultBucketName);
+ // mini pre-creates the bucket and only reports readiness once every
component,
Review Comment:
Would it make sense for `-bucket` to fail startup when creation fails,
instead of warning? That fixes it for everyone, not just us. Either way I want
the check here for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
