snuyanzin commented on code in PR #29200:
URL: https://github.com/apache/flink/pull/29200#discussion_r4021061590
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalLookupJoin.scala:
##########
@@ -187,14 +187,20 @@ abstract class CommonPhysicalLookupJoin(
case None =>
resultFieldNames.mkString(", ")
}
- val tableIdentifier: ObjectIdentifier = temporalTable match {
- case t: TableSourceTable => t.contextResolvedTable.getIdentifier
- case t: LegacyTableSourceTable[_] => t.tableIdentifier
+ // The abilities pushed into the temporal table, a filter above all, are
part of its identity:
+ // two lookup joins on the same table with different push-downs are
different operators. A
+ // TableSourceScan gets this for free because Calcite's TableScan digests
+ // RelOptTable#getQualifiedName, which TableSourceTable extends with its
spec digests.
Review Comment:
probably more succinct comment better imho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
