MartijnVisser opened a new pull request, #29226:
URL: https://github.com/apache/flink/pull/29226
## What is the purpose of the change
* `INSERT INTO t (col list) SELECT ... FROM f(TABLE t PARTITION BY k)`
failed with `must call validate first`. `PreValidateReWriter` validated the
source query once to rewrite it, and the planner then validated the same node
again with the same validator.
## Brief change log
* `PreValidateReWriter` only validates the static partitions and the target
column list
* The reordering, NULL padding and static partition constants become a
projection on the converted plan, like FLINK-40039 did for CTAS/RTAS
* Removed `SqlRewriterUtils`, which has no remaining users
## Verifying this change
This change added tests and can be verified as follows:
* `ToChangelogTest` and `ProcessTableFunctionTest` cover the failing
statement, four of the new tests fail on master
* `PartialInsertTest` covers the behaviour change the commit and the Jira
release note record
* Plan output for a partial insert changed, the golden files are regenerated
here
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
