pltbkd commented on PR #1127: URL: https://github.com/apache/flink-agents/pull/1127#issuecomment-5727210634
Hi @wenjin272, thanks for the PR — overall LGTM. I have a suggestion about the API. Do you think it's better to put `await` in `DurableFuture`, like `SubagentFuture`? It's close to the conventions of both Java and Python, and using `await` rather than `get` avoids misleading users into thinking this is a standard future. `gather` can stay on the context, consistent with Python. Also, with this change `requireOwnedFuture` can live inside `GatherDurableFuture`, so we don't have to introduce that method and its check on the context. WDYT? btw, `java.util.Set` shows up inline in the code — maybe we should add something to the AGENTS guide, or a format enforcer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
