Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3202
Thanks for the reviews.
It's more about readability of the code itself instead of testing and
visibility. The two functions are fairly long and basically identical.
Therefore I refactor the code a little bit to extract the common functions out
into the Util class.
To facilitate reviews I separate the changes into two commits. The first
commit contains the changes, and the second commit does the refactoring.
@StephanEwen please take another look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
