[
https://issues.apache.org/jira/browse/FLINK-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847434#comment-15847434
]
ASF GitHub Bot commented on FLINK-5631:
---------------------------------------
Github user haohui commented on the issue:
https://github.com/apache/flink/pull/3202
Thanks for the reviews.
It's more about readability of the code itself instead of testing and
visibility. The two functions are fairly long and basically identical.
Therefore I refactor the code a little bit to extract the common functions out
into the Util class.
To facilitate reviews I separate the changes into two commits. The first
commit contains the changes, and the second commit does the refactoring.
@StephanEwen please take another look.
> [yarn] Support downloading additional jars from non-HDFS paths
> --------------------------------------------------------------
>
> Key: FLINK-5631
> URL: https://issues.apache.org/jira/browse/FLINK-5631
> Project: Flink
> Issue Type: Bug
> Components: YARN
> Reporter: Haohui Mai
> Assignee: Haohui Mai
>
> Currently the {{YarnResourceManager}} and {{YarnApplicationMasterRunner}}
> always register the additional jars using the YARN filesystem object. This is
> problematic as the paths might require another filesystem.
> To support localizing from non-HDFS paths (e.g., s3, http or viewfs), the
> cleaner approach is to get the filesystem object from the path.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
