wenjin272 commented on issue #1085: URL: https://github.com/apache/flink-agents/issues/1085#issuecomment-5748143757
Thanks @yunfengzhou-hub, I agree with the descriptor-first field form, including the Python `action(...)(descriptor)` syntax. Since Python cannot apply `@action` to an assignment, this is the closest semantic equivalent to annotating a descriptor field in Java. One implementation detail: the decorator should return a separate immutable Action declaration rather than mutating the `Function` descriptor itself. A descriptor may be reused by multiple declarations, and attaching trigger metadata in place could cause one declaration to overwrite another. I think the validation timing also needs clarification. Today, Java class/method resolution and Python function import are still lazy. If the goal is to fail before processing records, the implementation should add explicit eager validation at the earliest boundary where the actual user-code classloader or Python interpreter is available. I would avoid promising that every Java target can be validated before job submission. I am open to removing the old placeholder-based forms in the 0.4 breaking window. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
