snuyanzin commented on code in PR #232:
URL:
https://github.com/apache/flink-connector-jdbc/pull/232#discussion_r4060483684
##########
flink-connector-jdbc-core/src/test/java/org/apache/flink/connector/jdbc/core/table/sink/JdbcDynamicTableSinkITCase.java:
##########
@@ -362,9 +363,14 @@ protected void testReadingFromChangelogSource() throws
Exception {
"'sink.buffer-flush.max-rows' = '2'",
"'sink.buffer-flush.interval' = '0'")));
+ String onConflict =
+ FlinkVersion.current().toString().compareTo("2.3") >= 0
Review Comment:
```
FlinkVersion.current().toString().compareTo("2.3") >= 0
```
probably better to extract it into helper method something like
`isFlip558Enabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
