Savonitar commented on code in PR #28639:
URL: https://github.com/apache/flink/pull/28639#discussion_r4064333184
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java:
##########
@@ -63,10 +64,42 @@ public interface ResourceManagerGateway
/**
* Register a {@link JobMaster} at the resource manager.
*
+ * <p>Backward-compatible overload that registers without a job
configuration. Equivalent to
+ * calling {@link #registerJobMaster(JobMasterId, ResourceID, String,
JobID, Configuration,
+ * Duration)} with an empty configuration.
+ *
+ * @param jobMasterId The fencing token for the JobMaster leader
+ * @param jobMasterResourceId The resource ID of the JobMaster that
registers
+ * @param jobMasterAddress The address of the JobMaster that registers
+ * @param jobId The Job ID of the JobMaster that registers
+ * @param timeout Timeout for the future to complete
+ * @return Future registration response
+ */
+ default CompletableFuture<RegistrationResponse> registerJobMaster(
Review Comment:
Removed in 7c131dabf3f and tests now pass the empty configuration explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
