dianfu commented on code in PR #29262:
URL: https://github.com/apache/flink/pull/29262#discussion_r4069972382
##########
flink-python/pyflink/dataframe/io.py:
##########
@@ -189,4 +192,45 @@ def read_generic(
source_schema = _build_source_schema(schema, computed_columns, watermark)
descriptor = _build_generic_descriptor(connector, options, source_schema)
table_environment = get_or_create_table_environment()
- return DataFrame(table_environment.from_descriptor(descriptor))
+ try:
+ table = table_environment.from_descriptor(descriptor)
+ except Exception as error:
+ _raise_as_value_error(error)
+ return DataFrame(table)
+
+
+@PublicEvolving()
+def read_catalog_table(path: str) -> DataFrame:
Review Comment:
Could we make the `read_catalog_table` API also accepts `computed_columns`
and `watermark`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
