csurong commented on code in PR #29245:
URL: https://github.com/apache/flink/pull/29245#discussion_r4078523296
##########
flink-python/pyflink/dataframe/dataframe.py:
##########
@@ -1369,6 +1369,205 @@ def columns(self) -> List[str]:
# ======================== I/O ========================
+ @PublicEvolving()
+ def write_parquet(
+ self,
+ path: str,
+ *,
+ mode: str = "overwrite",
Review Comment:
How about defaulting to append for both batch and streaming, consistent with
the non-overwrite behavior of Java’s Table.executeInsert() and write_generic()?
This would also avoid checking the execution mode in the Python wrapper.
Explicit overwrite would still work in batch and be rejected by the
filesystem connector in streaming. I’ll make that clear in the API docs.
This would change the batch default from overwrite in FLIP-591 too. Would
that be OK with you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
