MartijnVisser opened a new pull request, #248:
URL: https://github.com/apache/flink-connector-jdbc/pull/248

   ## What is the purpose of the change
   
   `JdbcTablePlanTest.testFilterPushdown` fails on the weekly run against Flink 
2.4-SNAPSHOT, because FLINK-40021 changed the pushed-down filter digest from 
`and(...)` to `AND(...)`. Push CI still builds `main` against 2.1.3 to 2.3.0, 
so one reference plan can't cover both.
   
   ## Brief change log
   
   - Add `testFilterPushdownSinceFlink24` with the `AND(` plan, and gate it and 
`testFilterPushdown` on `FlinkVersion.byCode("2.4")`, so each Flink version 
runs one of the two.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `JdbcTablePlanTest` fails on `main` against 2.4-SNAPSHOT as in 
https://github.com/apache/flink-connector-jdbc/actions/runs/35779813059/job/106922160950
 and passes with this change on 2.1.3, 2.2.1, 2.3.0 and 2.4-SNAPSHOT.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to