piotrp commented on code in PR #29120:
URL: https://github.com/apache/flink/pull/29120#discussion_r4083377473
##########
flink-core/src/test/java/org/apache/flink/util/MdcLogbackCompatibilityTest.java:
##########
@@ -50,10 +50,9 @@ void tearDown() throws Exception {
}
/**
- * The {@link MDC#setContextMap(Map)} method in Logback 1.2 does not
accept nulls, unlike Log4j
- * and Logback 1.3.2. BasicMDCAdapter is used to replicate this behavior
for testing without
- * bundling Logback into flink-core. See
https://issues.apache.org/jira/browse/FLINK-36227 for
- * details.
+ * Restoring an absent (null) MDC context must not fail, regardless of the
backend in use.
Review Comment:
Replaced with custom adapter that explicitly throws on
`setContextMap(null)`. I also renamed the test to be no longer Logback specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
