[
https://issues.apache.org/jira/browse/FLINK-40688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118584#comment-18118584
]
Purushottam Sinha commented on FLINK-40688:
-------------------------------------------
I think this can we closed as its being covered in FLINK-40687 PR already.
> flink-model-openai NOTICE lists httpcomponents artifacts it no longer bundles
> -----------------------------------------------------------------------------
>
> Key: FLINK-40688
> URL: https://issues.apache.org/jira/browse/FLINK-40688
> Project: Flink
> Issue Type: Bug
> Components: Library / Machine Learning
> Reporter: Martijn Visser
> Priority: Major
>
> The NOTICE of {{flink-model-openai}} lists
> {{org.apache.httpcomponents.client5:httpclient5:5.3.1}},
> {{org.apache.httpcomponents.core5:httpcore5:5.2.4}} and
> {{org.apache.httpcomponents.core5:httpcore5-h2:5.2.4}}, but the shaded jar
> contains no
> {{org/apache/hc}} entries at all. openai-java 1.6.1 pulled httpclient5 in at
> runtime scope, 4.63.1
> does not, and the bump in FLINK-40680 updated the {{com.openai}} versions and
> added the new
> victools, swagger and classmate entries without removing these three.
> The licence check only fails on missing entries, so this is not breaking
> anything, but the NOTICE
> claims we ship code we do not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
