sangkyoonnam commented on issue #970: URL: https://github.com/apache/flink-agents/issues/970#issuecomment-5805392777
Hi @Zhuoxi2000, are you still planning to pick this up? If not, I'd like to take it. I went through the #924 records and the agent-span conventions (now in `open-telemetry/semantic-conventions-genai`), and the mapping in the issue holds up against them. The only additions I'd make are `gen_ai.tool.call.id` and `gen_ai.tool.type` from the tool metadata keys, and `error.type` from `problemCategory` on failed executions. One thing I couldn't resolve: `gen_ai.provider.name` is required on `chat` spans, but I don't see the provider in `entityMetadata` for `llm` executions, so I'd leave it unset until the entityMetadata work from #929 lands unless you'd rather it come from somewhere else. Happy to adjust the scope if you had something different in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
