joeyutong commented on PR #1101: URL: https://github.com/apache/flink-agents/pull/1101#issuecomment-5807958529
Overall, this PR looks good to me. One pre-existing issue is worth tracking separately: a durable call result can be written to Kafka before a checkpoint while the action is still pending. Recovery starts from the checkpoint’s end offset, may miss that result, and may run the call again. This PR does not cause the issue, but cleanup may remove an older checkpoint and the records that could have provided a fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
