sangkyoonnam commented on PR #1151: URL: https://github.com/apache/flink-agents/pull/1151#issuecomment-5827413051
Two corrections to the description and one small commit. The old failure happened when the router was resolved on the TaskManager, before the durable routing call, not inside it. And only four of the five new `RoutingTest` cases fail without the api change: the blank-name constructor case already passed, because `RoutingCandidate` rejected blank names. While checking that I found `defaultModelMustBeCandidate` called `build()` inside the assertion, so it no longer reached the constructor, and a non-`String` `default_model` from a deserialized descriptor hit the `String` cast before the validator and threw `ClassCastException`. a2a7f8b8 reads it as `Object` so the validator rejects it, exercises the constructor directly in that test, and adds a case for the non-String value. One correction. The description said references with different memory types do not share a hash code, and the test asserted it. `Objects.hash(type, path)` does not guarantee that, so 81c2e1fc drops that assertion and the sentence; equal references sharing a hash is still asserted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
