eskabetxe commented on code in PR #250:
URL:
https://github.com/apache/flink-connector-jdbc/pull/250#discussion_r4102428432
##########
flink-connector-jdbc-postgres/src/test/java/org/apache/flink/connector/jdbc/postgres/testutils/PostgresDatabase.java:
##########
@@ -34,16 +34,12 @@ public class PostgresDatabase extends DatabaseExtension
implements PostgresImage
private static final PostgreSQLContainer<?> CONTAINER =
new
PostgresXaContainer(POSTGRES_16).withMaxConnections(10).withMaxTransactions(50);
- private static PostgresMetadata metadata;
-
public static PostgresMetadata getMetadata() {
if (!CONTAINER.isRunning()) {
throw new FlinkRuntimeException("Container is stopped.");
}
- if (metadata == null) {
Review Comment:
@MartijnVisser this change was introduced in
[FLINK-30790](https://issues.apache.org/jira/browse/FLINK-30790) to help speed
up the overall test execution. The approach is to create a single database
container for all tests and simply clean up the DB between each test class,
rather than spinning up a new one every time.
Did you check the test execution times before and after this change to see
the performance impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
